[PATCH] D99291: [AIX] Support init priority attribute

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 25 06:36:31 PDT 2021


aaron.ballman added inline comments.


================
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:574
+  std::string PrioritySuffix = llvm::utostr(Priority);
+  // Priority is always <= 65535 (enforced by sema).
+  PrioritySuffix = std::string(6 - PrioritySuffix.size(), '0') + PrioritySuffix;
----------------
This isn't quite true -- it's enforced by sema for user code, but not for code that identifies itself as a system header. I see that this is existing code that's moved around a bit, but we may want to add an assertion here just in case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99291/new/

https://reviews.llvm.org/D99291



More information about the cfe-commits mailing list