[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

Abhina Sree via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 25 05:16:27 PDT 2021


abhina.sreeskantharajan marked an inline comment as done.
abhina.sreeskantharajan added inline comments.


================
Comment at: llvm/lib/Support/MemoryBuffer.cpp:275
+  return getFileAux<WritableMemoryBuffer>(
+      Filename, /*MapSize=*/-1, 0, /*IsText=*/false,
+      /*RequiresNullTerminator=*/false, IsVolatile);
----------------
jhenderson wrote:
> Whilst you're modifying, add the named parameter comment for the `0`, so that it's not just a magic number.
Thanks for catching, this is fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99182/new/

https://reviews.llvm.org/D99182



More information about the cfe-commits mailing list