[PATCH] D98554: Save strings for CC_PRINT env vars

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 24 15:05:22 PDT 2021


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM; thanks.



================
Comment at: clang/lib/Driver/Driver.cpp:4042
 
-      if (!CCPrintStatReportFilename) {
+      if (CCPrintStatReportFilename.empty()) {
         using namespace llvm;
----------------
Just noting that this means having the environment variable set (but empty) will now "work" instead of generating an error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98554/new/

https://reviews.llvm.org/D98554



More information about the cfe-commits mailing list