[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 24 12:25:28 PDT 2021
aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30
+ if (!FuncClassifier)
+ FuncClassifier.emplace(*Result.Context);
+
----------------
njames93 wrote:
> aaron.ballman wrote:
> > This is racy, but I don't think we support running multiple checks in parallel, do we?
> This isn't racy as one instance of a check will only ever run on one thread.
I was thinking if the check gets run multiple times in parallel on different source files (e.g., someone downstream who incorporates the checks as a library in a creative way rather than runs clang-tidy as a command line tool). But yeah, I'm not worried about it as I don't think we support that sort of thing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98275/new/
https://reviews.llvm.org/D98275
More information about the cfe-commits
mailing list