[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9
+// RUN:   -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t
+// RUN: FileCheck --check-prefix=ASM --allow-empty %s <%t
+
----------------
jrtc27 wrote:
> khchen wrote:
> > nit: skip the temporary file and remove +experimental-zfh and -fallow-half-arguments-and-returns.
> Can we please stop putting ASM tests in Clang, and if they really are needed, splitting them out into their own files separate from the IR tests?
For more background, this approach was copied from AArch64 SVE where they said this was beneficial to catch warnings from TypeSize's implicit conversion to uint64_t.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99151/new/

https://reviews.llvm.org/D99151