[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 24 03:36:48 PDT 2021
jansvoboda11 added a comment.
In D97462#2644406 <https://reviews.llvm.org/D97462#2644406>, @arichardson wrote:
> How expensive are these checks? If it is non-trivial overhead, maybe it should default to `${LLVM_ENABLE_EXPENSIVE_CHECKS}` instead?
Thanks for bringing that up. I measured the performance overhead of round-tripping here: https://reviews.llvm.org/D95516. Command-line parsing itself is ~3x slower, but still takes under .5 ms. Compared to other parts of the compiler, this is insignificant.
Changing the default to `LLVM_ENABLE_EXPENSIVE_CHECKS` would shift the check from local development to post-commit testing on built bots for most people. I don't think that would be a great trade-off.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97462/new/
https://reviews.llvm.org/D97462
More information about the cfe-commits
mailing list