[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

Tue Mar 23 22:22:17 PDT 2021

lxfind added a comment.

In D99227#2646568 <https://reviews.llvm.org/D99227#2646568>, @ChuanqiXu wrote:

> Only one problem I had for emitting lifetime markers even at O0 is that would action make allocas to be optimized even at O0? If so, I wonder if it confuses programmers since they may find some variables disappear surprisingly. Or there would be no optimization since every function would be marked with optnone attribute. I am not sure about this.

It will only cause variables to be put on the stack instead of on the frame, which shouldn't affect developer's view?

> If I understand this problem correctly, this patch could fix problems for the return value of symmetric transfer and the gro that we discussed in D98638 <https://reviews.llvm.org/D98638>. Then D98638 <https://reviews.llvm.org/D98638> may be unneeded. I prefer the implementation in this patch.

I doubt it can fix the gro problem. I will need to double check on that latter.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99227/new/

https://reviews.llvm.org/D99227