[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

Mon Mar 22 21:41:43 PDT 2021

khchen added a comment.

In D99082#2643322 <https://reviews.llvm.org/D99082#2643322>, @jrtc27 wrote:

> Most likely because you're adding assembly tests in Clang, which won't work if the backend isn't present (and needs a REQUIRES line). Assembly tests in Clang are generally bad practice and best avoided for that reason. If you do want them it's probably best to split them out into their own tests so people can still run the frontend tests regardless.

@jrtc27 Thanks for point out the problem.
It seems ARM and PPC intrinsic did the same way too. (test assembly in clang with REQUIRES line)
I also feel it's not a good practice, but it's really helpful to find a frontend bug when generated intrinsic IR can not selected in the backend.
It also could help on point out the error if any intrinsic IR are changed.

Do you mean using the same file content in different file for different test purpose?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99082/new/

https://reviews.llvm.org/D99082