[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

Mon Mar 22 17:23:04 PDT 2021

akhuang added a comment.

In D97411#2642782 <https://reviews.llvm.org/D97411#2642782>, @dblaikie wrote:

> In D97411#2642194 <https://reviews.llvm.org/D97411#2642194>, @akhuang wrote:
>
>>> Hmm - is that type used in a way that invokes Undefined Behavior? Or is this a gap/bug in the ctor homing? I thought there was already a special case for constexpr ctors that opted them out of ctor homing.
>>
>> Right, I think the constexpr is only used in >c++17 for some reason, so doesn't apply here. I looked around a bit but still not sure how/where `allocator`s are constructed.
>
> Fair enough - guess that's a discussion to have on a separate thread/when we talk about adding the attribute to libc++/or when bugfixing the ctor homing, if it turns out/looks like a gap in ctor homing to address there. (happy to discuss it whenever - email/chat/etc)

Oh, I have already created a patch for adding to libc++ (https://reviews.llvm.org/D98750), although no comments on it yet.

Yeah, I'll try to figure out what's going on with `allocator`; I wasn't planning on adding the attribute there though because it didn't seem to affect displaying the debug info

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97411/new/

https://reviews.llvm.org/D97411