[PATCH] D94355: [Passes] Add relative lookup table converter pass
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 22 15:36:56 PDT 2021
thakis added inline comments.
================
Comment at: llvm/utils/gn/secondary/llvm/lib/Transforms/Utils/BUILD.gn:64
"PromoteMemoryToRegister.cpp",
+ "RelLookupTableConverter.cpp"
"SSAUpdater.cpp",
----------------
leonardchan wrote:
> Good that you added this, but I think Nico has a bot that automatically updates these BUILD.gn files so manually updating them may not be necessary.
Please don't touch gn files unless you use them. Simple file additions in cmake files are synced automatically http://github.com/llvmgnsyncbot
You forgot to add the trailing comma and now I had to fix it up manually instead of doing nothing :P
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94355/new/
https://reviews.llvm.org/D94355
More information about the cfe-commits
mailing list