[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

[Nikita Kniazev via Phabricator via cfe-commits]

nick added a comment.

Is this hack actually needed? I could not reproduce a problem with https://bugs.chromium.org/p/chromium/issues/detail?id=860398#c13 repro, the breakpoint fires for me and I see the variable.

The difference with the hack and without, using `clang.exe src.cpp -S -masm=intel -O2 -g -o out.asm` is

  diff
  ---
  +++
  @@ -26,10 +26,10 @@
          .seh_stackalloc 32
          .seh_endprologue
   .Ltmp0:
  -       #DEBUG_VALUE: test0:x <- [DW_OP_deref] $rcx
  +       #DEBUG_VALUE: test0:x <- [$rcx+0]
          mov     rsi, rcx
   .Ltmp1:
  -       #DEBUG_VALUE: test0:x <- [DW_OP_deref] $rsi
  +       #DEBUG_VALUE: test0:x <- [$rsi+0]
          .cv_loc 0 1 9 0                         # nrvox.cpp:9:0
          call    "??0X@@QEAA at XZ"
          .cv_loc 0 1 10 0                        # nrvox.cpp:10:0




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99107/new/

https://reviews.llvm.org/D99107