[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

Mon Mar 22 10:36:22 PDT 2021

tra added a comment.

In D98902#2640477 <https://reviews.llvm.org/D98902#2640477>, @tianshilei1992 wrote:

> In D98902#2636308 <https://reviews.llvm.org/D98902#2636308>, @jdoerfert wrote:
>
>> @tra, so you think we should not do this? The user will see a link error late I assume, might be better.
>
> I think @tra 's point is we should not do that for CUDA code. This change only affects OpenMP.

Correct. We do want to ling with libdevice during CUDA compilation, even with -S. I don't have a strong opinion on what OpenMP does.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98902/new/

https://reviews.llvm.org/D98902