[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv32-zbr.c:5
+
+#include <rvintrin.h>
+
----------------
I don't think this include is needed. You're calling the __builtin names directly.


================
Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbr.c:5
+
+#include <rvintrin.h>
+
----------------
Same here


================
Comment at: clang/test/Headers/rvintrin.c:7
+
+#include <rvintrin.h>
----------------
This should be in the D99008 patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99009/new/

https://reviews.llvm.org/D99009