[PATCH] D55212: Handle alloc_size attribute on function pointers

Mon Mar 22 08:04:54 PDT 2021

aaron.ballman accepted this revision.
aaron.ballman added a comment.

In D55212#2641402 <https://reviews.llvm.org/D55212#2641402>, @erik.pilkington wrote:

> In D55212#2641301 <https://reviews.llvm.org/D55212#2641301>, @aaron.ballman wrote:
>
>> I think folks will have a chance to react if we apply it to trunk now, but I am wondering if anyone's had a chance to investigate usage in the wild. @erik.pilkington or @dexonsmith, do either of you have a gut feeling?
>
> I don't see any uses of #pca with alloc_size in our internal codebase. IMO I'd be really quite surprised if anyone actually used these two features together.

Thank you for the feedback! Then I think this continues to LGTM -- if there is breakage in the wild, we can hopefully react to it.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55212/new/

https://reviews.llvm.org/D55212