[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.
Balázs Kéri via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 22 03:09:11 PDT 2021
balazske created this revision.
Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
balazske requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Update ASTImporter to import value of FieldDecl::getCapturedVLAType.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D99062
Files:
clang/lib/AST/ASTImporter.cpp
clang/unittests/AST/ASTImporterTest.cpp
Index: clang/unittests/AST/ASTImporterTest.cpp
===================================================================
--- clang/unittests/AST/ASTImporterTest.cpp
+++ clang/unittests/AST/ASTImporterTest.cpp
@@ -6208,6 +6208,24 @@
EXPECT_TRUE(To2);
}
+TEST_P(ASTImporterOptionSpecificTestBase, ImportOfCapturedVLAType) {
+ const auto *Code =
+ R"(void declToImport(int N) {
+ int VLA[N];
+ [&VLA] {}; // FieldDecl inside the lambda.
+ })";
+
+ Decl *FromTU = getTuDecl(Code, Lang_CXX14, "input.cpp");
+ auto *FromFD = FirstDeclMatcher<FieldDecl>().match(FromTU, fieldDecl());
+ ASSERT_TRUE(FromFD);
+ ASSERT_TRUE(FromFD->hasCapturedVLAType());
+
+ auto *ToFD = Import(FromFD, Lang_CXX14);
+ EXPECT_TRUE(ToFD);
+ EXPECT_TRUE(ToFD->hasCapturedVLAType());
+ EXPECT_NE(FromFD->getCapturedVLAType(), ToFD->getCapturedVLAType());
+}
+
INSTANTIATE_TEST_CASE_P(ParameterizedTests, ASTImporterLookupTableTest,
DefaultTestValuesForRunOptions, );
Index: clang/lib/AST/ASTImporter.cpp
===================================================================
--- clang/lib/AST/ASTImporter.cpp
+++ clang/lib/AST/ASTImporter.cpp
@@ -3631,6 +3631,10 @@
auto ToInitializer = importChecked(Err, D->getInClassInitializer());
if (Err)
return std::move(Err);
+ const Type *ToCapturedVLAType = nullptr;
+ if (Error Err = Importer.importInto(
+ ToCapturedVLAType, cast_or_null<Type>(D->getCapturedVLAType())))
+ return std::move(Err);
FieldDecl *ToField;
if (GetImportedOrCreateDecl(ToField, D, Importer.getToContext(), DC,
@@ -3644,6 +3648,8 @@
if (ToInitializer)
ToField->setInClassInitializer(ToInitializer);
ToField->setImplicit(D->isImplicit());
+ if (ToCapturedVLAType)
+ ToField->setCapturedVLAType(cast<VariableArrayType>(ToCapturedVLAType));
LexicalDC->addDeclInternal(ToField);
return ToField;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99062.332227.patch
Type: text/x-patch
Size: 1891 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210322/88b5bd9f/attachment.bin>
More information about the cfe-commits
mailing list