[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

[Florian Hahn via Phabricator via cfe-commits]

fhahn requested changes to this revision.
fhahn added reviewers: rjmccall, rsmith, erichkeane.
fhahn added a comment.
This revision now requires changes to proceed.

Thanks for the patch! I think this also needs changes in code-gen & code-gen tests.



================
Comment at: clang/include/clang/Sema/Sema.h:11667
+  // CheckMatrixCast - check type constraints for matrices.
+  // We allow casting in between matrices of the same dimensions i.e. when
+  // they have the same number of rows and columns.
----------------
nit: casting beween


================
Comment at: clang/include/clang/Sema/Sema.h:11669
+  // they have the same number of rows and columns.
+  // returns true if the cast is invalid
+  bool CheckMatrixCast(SourceRange R, QualType MatrixTy, QualType Tr,
----------------
nit: should be a full sentence and also go in the previous row?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037