[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

Arnamoy B via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 19 12:51:56 PDT 2021


arnamoy10 added inline comments.


================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:298
+  driverPath.append("/../include/flang/");
+  return driverPath.str().str();
+}
----------------
awarzynski wrote:
> Given this [[ https://github.com/llvm/llvm-project/blob/987ee6e3cc1fb672b3ed201e72a5281c2ec88c99/llvm/include/llvm/ADT/SmallString.h#L271-L273 | conversion operator ]], wouldn't `return std::string(driverPath);` be more efficient? 
Done, thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97080/new/

https://reviews.llvm.org/D97080



More information about the cfe-commits mailing list