[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

Maxim Kuvyrkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 19 03:00:34 PDT 2021


maxim-kuvyrkov created this revision.
maxim-kuvyrkov added reviewers: asl, phosek.
maxim-kuvyrkov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

At the moment "link.exe" is hard-coded as default linker in MSVC.cpp,
so there's no way to use LLD as default linker for MSVC driver.

This patch adds checking of CLANG_DEFAULT_LINKER to MSVC.cpp and
updates unit-tests that expect link.exe linker to explicitly select it
via -fuse-ld=link, so that buildbots and other builds that set
-DCLANG_DEFAULT_LINKER=foobar don't fail these tests.

This is a squash of

- https://reviews.llvm.org/D98493 (MSVC.cpp change) and
- https://reviews.llvm.org/D98862 (unit-tests change)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98935

Files:
  clang/lib/Driver/ToolChains/MSVC.cpp
  clang/test/Driver/Xlinker-args.c
  clang/test/Driver/cl-inputs.c
  clang/test/Driver/cl-link-at-file.c
  clang/test/Driver/cl-link.c
  clang/test/Driver/msvc-link.c
  clang/test/OpenMP/linking.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98935.331809.patch
Type: text/x-patch
Size: 9444 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210319/b8d7d078/attachment-0001.bin>


More information about the cfe-commits mailing list