[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

Maxim Kuvyrkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 19 00:41:40 PDT 2021


maxim-kuvyrkov added a comment.

In D98493#2636616 <https://reviews.llvm.org/D98493#2636616>, @phosek wrote:

> They're not part of buildbot but they're not internal, you can see the log here: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8852352747956966400/+/u/clang/test/stdout.
>
> I noticed D98862 <https://reviews.llvm.org/D98862>, but it still hasn't landed and given that it's been 24 hours since your change landed and anyone who is using `CLANG_DEFAULT_LINKER` is currently broken (I for example use this option in my local build and tests have been failing for me locally as well), I think it's it better to revert this change and then reland it once your fix is ready.

Would you please test D98862 <https://reviews.llvm.org/D98862> (which I've just updated) on top of this patch and see that completely fixes your bots?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98493/new/

https://reviews.llvm.org/D98493



More information about the cfe-commits mailing list