[PATCH] D98867: [HIP] Fix ROCm detection

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 18 11:08:38 PDT 2021


tra added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:271
+    }
+    if (LatestROCm < FileName)
+      LatestROCm = FileName.str();
----------------
This will rank `rocm-3.9` higher than `rocm-3.10`. I think you do need to extract and compare the version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98867/new/

https://reviews.llvm.org/D98867



More information about the cfe-commits mailing list