[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions
Whisperity via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 18 09:17:13 PDT 2021
whisperity marked 5 inline comments as done.
whisperity added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:377
+
+ bool indicatesMixability() const { return Flags > MIX_None; }
+
----------------
aaron.ballman wrote:
> Should this be `MIX_WorkaroundDisableCanonicalEquivalence` instead of `MIX_None`?
In this patch I changed the value of `None` to be `2`, and `Workaround...` became `1`. So everything above `None` means it's a valid mixability (somehow), of course only after `sanitize()` so `Workaround... | CanonicalType` becomes `None`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75041/new/
https://reviews.llvm.org/D75041
More information about the cfe-commits
mailing list