[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

[Janusz Nykiel via Phabricator via cfe-commits]

jnykiel updated this revision to Diff 331570.
jnykiel retitled this revision from "[Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+" to "[Tooling] Handle compilation databases containing commands with double dashes".
jnykiel edited the summary of this revision.
jnykiel added a comment.

I have addressed some of your comments. The second revision is good enough to get the tests to pass - the `injectResourceDir` change was necessary for the one clang-tidy test that started failing after leaving the `--` in. I don't feel familiar enough with clangd specifically to attempt comprehensive fixes there. The clangd issue report specifically mentions `-fsyntax-only` and `-resource-dir` as well - so while not comprehensive, the fix may be good for that too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98824/new/

https://reviews.llvm.org/D98824

Files:
  clang/lib/Tooling/ArgumentsAdjusters.cpp
  clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
  clang/lib/Tooling/Tooling.cpp
  clang/unittests/Tooling/CompilationDatabaseTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98824.331570.patch
Type: text/x-patch
Size: 4347 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210318/d6d27b8d/attachment-0001.bin>