[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

Zakk Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 17 20:34:42 PDT 2021


khchen marked an inline comment as done.
khchen added inline comments.


================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:700
+    for (auto Idx : CTypeOrder) {
+      if (Seen.count(Idx))
+        PrintFatalError(
----------------
craig.topper wrote:
> You can use
> 
> ```
> if (!Seen.insert(Idx).second)
>   PrintFatalError
> ```
> 
> This avoids walking the set twice.
> 
Fixed directly in upstream patch. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98388/new/

https://reviews.llvm.org/D98388



More information about the cfe-commits mailing list