[PATCH] D98824: [Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 17 16:25:36 PDT 2021


aganea added inline comments.


================
Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:181
+      // ...including when the inputs are passed after --
+      if (Opt.matches(OPT__DASH_DASH)) {
+        continue;
----------------
You can leave out the braces on a one-line statement: https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98824/new/

https://reviews.llvm.org/D98824



More information about the cfe-commits mailing list