[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 17 02:04:40 PDT 2021


NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:343
+  if (!DRV.isEmpty()) {
+    Out << Sep << "Mutex destroys with unknown result:" << NL;
+    for (auto I : DRV) {
----------------
balazske wrote:
> NoQ wrote:
> > I think this should be passive. The mutex doesn't actively destroy anybody.
> Maybe "Mutex destroy calls with unknown result:"? This is a title of a list, not about a single mutex.
Oh that's what you meant, I see.

"[[ https://stackoverflow.com/questions/866837/plural-form-of-word-mutex#comment674585_866837 | Mutexes  ]] in unresolved possibly destroyed state:"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98502/new/

https://reviews.llvm.org/D98502



More information about the cfe-commits mailing list