[PATCH] D98726: [analyzer] Remove unnecessary TODO

Deep Majumder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 17 00:18:37 PDT 2021


RedDocMD added a comment.

@NoQ, regarding https://godbolt.org/z/1EczEW, I don't think there should be a warning since the original pointer may be needed in the caller.
But thanks for pointing out the possible leaks due to release! :)
In the line that you have pointed out, I have thought about the following cases which should have a warning (but currently don't):

- https://godbolt.org/z/dzszWd (leak from explicit new)
- https://godbolt.org/z/rdbKn3 (leak from `unique_ptr` created from `make_unique`)
- https://godbolt.org/z/Y6d5qE (use after delete of passed pointer)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98726/new/

https://reviews.llvm.org/D98726



More information about the cfe-commits mailing list