[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy
Stephen Kelly via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 16 15:45:58 PDT 2021
steveire added inline comments.
================
Comment at: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp:285
+#include "path/to/header2.h"
+#include "path/to/header.h"
+
----------------
njames93 wrote:
> steveire wrote:
> > I still find it really confusing that the "single inserter" mode results in multiple of the same header being added. Perhaps the names should be along the lines of "duplicating" and "deduplicating" instead of "single" and "multi"?
> The name of the test is `InsertMultipleIncludesNoDeduplicate`, Is that not sufficient?
Yes, the comment you're responding to here is quite old and predates the renaming.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97121/new/
https://reviews.llvm.org/D97121
More information about the cfe-commits
mailing list