[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

[Luís Marques via Phabricator via cfe-commits]

luismarques added a comment.

This still doesn't report that the multilib configuration came from GCC when it succeeds, does it? I suppose that's not a deal-breaker, but it would be nice to have. Would it be difficult to implement?

Regarding the Windows test issue, aren't there other test cases in similar situations that managed to sort that out?



================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1659
+  for (StringRef Line : Lines) {
+    if (Line.trim().empty())
+      continue;
----------------
I was actually thinking something along the lines of `Line = Line.trim();`, so that the rest of the parsing code would also benefit from having any extraneous whitespace removed and thus be more robust. Or does this mutate the argument?


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1742
+  if (RC != 0) {
+    MultilibErrorMessages = "Read GCC multilib configureation failed due to "
+                            "non-zero return code";
----------------
configureation -> configuration. Also, the user won't know what the "non-zero return code" refers to. How about something like "Failed to execute <path> in an attempt to obtain the multilib configuration from GCC"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97916/new/

https://reviews.llvm.org/D97916