[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

Tue Mar 16 12:07:34 PDT 2021

njames93 added a comment.

In D98635#2629827 <https://reviews.llvm.org/D98635#2629827>, @whisperity wrote:

> @aaron.ballman Could you please help me understand this pre-merge buildbot? It says that Debian failed, with the following message:
>
>   [15/1038] Running lint check for sanitizer sources...
>   FAILED: projects/compiler-rt/lib/CMakeFiles/SanitizerLintCheck
>   cd /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/lib && env LLVM_CHECKOUT=/mnt/disks/ssd0/agent/llvm-project/llvm SILENT=1 TMPDIR= PYTHON_EXECUTABLE=/usr/bin/python3.8 COMPILER_RT=/mnt/disks/ssd0/agent/llvm-project/compiler-rt /mnt/disks/ssd0/agent/llvm-project/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
>   The following differences between the ABI list and the implemented custom wrappers have been found:
>
> Should I be worried because of this, or is this that the patch started building when the main branch was broken? I haven't touched `compiler-rt` at all. Neither anything that deals with the sanitizers. And this fail is "earlier" than the previous one where I indeed missed a test file's update. (Previous fail was at ninja action multiple hundreds, this is 15.)
>
> And it talks about a lot of stuff like `fork` and such that is really really out of scope for the patch itself.

Rule of thumb: If the test failures don't seem related to the contents of your patch, they can usually be disregarded as its likely something on trunk that is causing the failure.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98635/new/

https://reviews.llvm.org/D98635