[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check
Whisperity via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 16 10:21:20 PDT 2021
whisperity added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:56
+
+#ifndef NDEBUG
+
----------------
aaron.ballman wrote:
> Are you planning to remove the debugging code now that the check is approaching its final form?
Actually, I would prefer not to. I removed every debug thing possible. However, and this is speaking from experience because I wrote this check two times already from basically scratch... the rest of the debug code that is part of the patch has to be there. If anything goes nuts, especially if there would be false positives later... it would be impossible to figure out what is going on during the modelling without seeing all the steps being taken.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69560/new/
https://reviews.llvm.org/D69560
More information about the cfe-commits
mailing list