[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

Ilya Kuteev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 16 09:52:54 PDT 2021


ilyakuteev added a comment.

If a fix will be in ModuleManager and only for ModuleCache the problem with symlinks and path will not affect it as ModuleCache is managed by clang and we can rely on it.
I agree that using `FileMgr.getBypassFile` is not the best way to solve this problem, we need to replace `FileMgr.getFileRef` with some other method but I did not found such method in FileManager. Maybe we need to add one or not use FileManager as was mentioned. Not sure which way is better and safer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97850/new/

https://reviews.llvm.org/D97850



More information about the cfe-commits mailing list