[PATCH] D98707: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 16 08:05:59 PDT 2021


balazske added a comment.

Looks good, just find a better place for the test.



================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:817
 
+TEST_P(ImportDecl, ImportedVarDeclPreservesThreadLocalStorage) {
+  MatchVerifier<Decl> Verifier;
----------------
The test can be moved to better place, probably after line 3481 and use `ImportVariables`. At least I want it not between two related tests, here between `ImportUsingDecl` and `ImportUsingShadowDecl`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98707/new/

https://reviews.llvm.org/D98707



More information about the cfe-commits mailing list