[PATCH] D98411: [OpenCL] Respect calling convention for builtin

Luke Drummond via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 16 05:20:07 PDT 2021


ldrumm added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6268
+  auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false);
+  auto *Call = CGF.Builder.CreateCall(
+      CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C});
----------------
Anastasia wrote:
> Btw I think we should be using `CodeGenFunction::EmitRuntimeCall` here instead because it sets the CC correctly through `SPIRABIInfo`.
> 
Thanks. I'll prepare a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98411/new/

https://reviews.llvm.org/D98411



More information about the cfe-commits mailing list