[PATCH] D98664: Fix crash on dumping AST containing constant initializer with ParenListExpr
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 16 04:33:28 PDT 2021
aaron.ballman added a comment.
As far as the changes go, these seem reasonable to me, though I find it a bit odd that these are expressions without a type whereas a `ParenExpr` has a type of the underlying parenthesized expression. e.g.,
int x(0); // (0) has void type
int y = (0); // (0) has int type
I think my natural assumption is that the init expression would have the type of the thing that's being initialized.
Despite that, I think the changes LG, but I'd like to hear from @rsmith.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98664/new/
https://reviews.llvm.org/D98664
More information about the cfe-commits
mailing list