[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

Tue Mar 16 04:23:47 PDT 2021

zero9178 added a comment.

In D98278#2628527 <https://reviews.llvm.org/D98278#2628527>, @uabelho wrote:

> In D98278#2628482 <https://reviews.llvm.org/D98278#2628482>, @zero9178 wrote:
>
>> In D98278#2628477 <https://reviews.llvm.org/D98278#2628477>, @uabelho wrote:
>>
>>> so perhaps there should be some additional error handling when running the compiled program doesn't work?
>>
>> Could you try changing line 32 of llvm/cmake/modules/GetErrcMessages.cmake from `if (errc_compiled)` to `if (errc_compiled AND "${errc_exit_code}" STREQUAL "0")` and report back if it changes anything? I think that should fix your issue, although it'll fall back to using python's strerror messages. Indeed an oversight of mine.
>
> Yes that helps, please submit. Thanks!

Pushed in https://reviews.llvm.org/rG953bb5e5c8f60dc769942a3615d800fe166ffd1d

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98278/new/

https://reviews.llvm.org/D98278