[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

Digger Lin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 15 13:48:17 PDT 2021


DiggerLin created this revision.
DiggerLin added reviewers: hubert.reinterpretcast, jasonliu, sfertile, daltenty.
Herald added a subscriber: arphaman.
DiggerLin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

because we enable -mignore-xcoff-visibility by default when there is no -fvisibility option in the clang in AIX OS
it will cause  some test case fail at aix os. in order to let the -mignore-xcoff-visibility to be disable, we need to add the -fvisibility=default for those test case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98660

Files:
  clang/test/CodeGen/hidden-visibility.c
  clang/test/CodeGen/private-extern.c
  clang/test/Index/symbol-visibility.c


Index: clang/test/Index/symbol-visibility.c
===================================================================
--- clang/test/Index/symbol-visibility.c
+++ clang/test/Index/symbol-visibility.c
@@ -1,4 +1,4 @@
-// RUN: c-index-test -test-print-visibility %s | FileCheck %s
+// RUN: c-index-test -test-print-visibility  -fvisibility=default %s | FileCheck %s
 
 __attribute__ ((visibility ("default"))) void foo1();
 __attribute__ ((visibility ("hidden"))) void foo2();
Index: clang/test/CodeGen/private-extern.c
===================================================================
--- clang/test/CodeGen/private-extern.c
+++ clang/test/CodeGen/private-extern.c
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1  -fvisibility default -emit-llvm -o - %s | FileCheck %s
 
 // CHECK-DAG: @g0 = external hidden constant i32
 // CHECK-DAG: @g1 = hidden constant i32 1
Index: clang/test/CodeGen/hidden-visibility.c
===================================================================
--- clang/test/CodeGen/hidden-visibility.c
+++ clang/test/CodeGen/hidden-visibility.c
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s
+// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s
 
 // CHECK: hidden global
 int X __attribute__ ((__visibility__ ("hidden"))) = 123;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98660.330796.patch
Type: text/x-patch
Size: 1331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210315/9c4bc924/attachment.bin>


More information about the cfe-commits mailing list