[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 15 13:18:59 PDT 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm w nit



================
Comment at: clang/test/CodeGen/wmemchr.c:7
+const wchar_t *wmemchr_test(const wchar_t *s, const wchar_t c, size_t n) {
+  // CHECK: [[S:%.*]] = load
+  // CHECK: [[C:%.*]] = load
----------------
I'd start these off with `CHECK-LABEL: define i16* @wmemchr_test` as a little bit of future proofing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98472/new/

https://reviews.llvm.org/D98472



More information about the cfe-commits mailing list