[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 15 12:12:39 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/patchable-function-entry.ll:24
+; RVC-NEXT:      c.jr ra
+; CHECK:       .section __patchable_function_entries,"awo", at progbits,f1{{$}}
+; 32:          .p2align 2
----------------
jrtc27 wrote:
> Is there a benefit from treating these like labels with CHECK-LABEL?
I don't find a difference regarding the diagnostic.

The `<stdin>:29:2: note: possible intended match here\n    .section __patchable_function_entries,"awo", at progbits,f1` lines do not change. So `-LABEL:` does not improve diagnostic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98610/new/

https://reviews.llvm.org/D98610



More information about the cfe-commits mailing list