[PATCH] D94355: [Passes] Add relative lookup table converter pass

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 15 12:04:30 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:390-391
+
+    if (!TM.getTargetTriple().isArch64Bit())
+      return false;
+
----------------
1. But all tests are using `x86_64` triple?
2. This is somewhat backwards. if the target wants to disable this, it will need to override this function with `return false;`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94355/new/

https://reviews.llvm.org/D94355



More information about the cfe-commits mailing list