[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

Jonas Paulsson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 15 11:59:55 PDT 2021


jonpa updated this revision to Diff 330753.
jonpa added a comment.

> This "invert" logic doesn't look correct. "isfinite" and "isinf" both need to return false on NaNs. I think you should just drop the invert logic and use a TDC mask of 0xFC0 (zero, normal, or subnormal) to implement "isfinite".

Rebased and updated per review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97901/new/

https://reviews.llvm.org/D97901

Files:
  clang/lib/CodeGen/TargetInfo.cpp
  clang/test/CodeGen/SystemZ/strictfp_builtins.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97901.330753.patch
Type: text/x-patch
Size: 5478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210315/5cf056cd/attachment.bin>


More information about the cfe-commits mailing list