[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS
Abhina Sree via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 15 11:49:46 PDT 2021
abhina.sreeskantharajan marked 2 inline comments as done.
abhina.sreeskantharajan added a comment.
In D97785#2626427 <https://reviews.llvm.org/D97785#2626427>, @zibi wrote:
> LGTM, I just wonder if we can make an extra parameter to be default. I notice some places that is a default parameter but not in all instances. With default parameter some of the calls might be simplified if there is no need to override it.
Thanks for reviewing. Do you have an example of which function is missing a default? The functions I modified in the .h files all have defaults to OF_None or binary. I can make another patch for additional changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97785/new/
https://reviews.llvm.org/D97785
More information about the cfe-commits
mailing list