[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

Mon Mar 15 11:45:00 PDT 2021

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm!

================
Comment at: clang-tools-extra/clangd/CMakeLists.txt:190
 option(CLANGD_ENABLE_REMOTE "Use gRPC library to enable remote index support for Clangd" OFF)
+option(ENABLE_GRPC_REFLECTION "Link clangd-index-server to gRPC Reflection library" OFF)
 set(GRPC_INSTALL_PATH "" CACHE PATH "Path to gRPC library manual installation.")
----------------
i think this option belongs to `FindGRPC.cmake`, as it configures the grpc linking behavior in general, not something specific to clangd.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98404/new/

https://reviews.llvm.org/D98404