[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

I'm not opposed to the attribute per se, but I'd like to understand the motivation behind it a bit more. It seems like it solves a special edge case for a specific linker and I'm wondering if that's sufficient motivation for the community to support the attribute or not.



================
Comment at: clang/test/Sema/attr-addrsig.c:8
+
+struct __attribute__((addrsig)) A {}; // expected-warning {{'addrsig' attribute only applies to functions and variables}}
----------------
You should also have a test that the attribute does not accept any arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98295/new/

https://reviews.llvm.org/D98295