[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

[Stelios Ioannou via Phabricator via cfe-commits]

stelios-arm added inline comments.


================
Comment at: clang/test/CodeGen/arm_acle.c:908
+#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG)
+// AArch64-v8_3-LABEL: @test_rndr(
+// AArch64-v8_3-NEXT:  entry:
----------------
SjoerdMeijer wrote:
> stelios-arm wrote:
> > SjoerdMeijer wrote:
> > > Not sure if I am surprised that this works.... This is (re)using tag `AArch64-v8_3` and for the other tests that use this and don't have RNG set, I was expecting FileCheck to complain about this, not sure if I am missing something though.
> > It turns out that this test is disabled (https://github.com/llvm/llvm-project/commit/6fcd4e080f09c9765d6e0ea03b1da91669c8509a). I am going to remove the changes in this file. 
> But this seems to be a useful test to have. Are we testing this elsewhere now?
@dmgreen created a patch to re-enable this test (https://reviews.llvm.org/D98510). I am going to add the tests again. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98264/new/

https://reviews.llvm.org/D98264