[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

Caroline via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 15 02:03:16 PDT 2021


CarolineConcatto added a comment.

Hi @ bsmith,

Thank you for adding me as a reviewer, although I don't think I am the more qualified to approve or not this patch.
But I have a question: 
Why is this patch only changing int_aarch64_neon_frintn and not int_aarch64_sve_frintn?
Is there a particular reason to do so? 
As you said in the commit message the ISD node for FROUNDEVEN exists now.
If so it would be too much to explain that in the commit message?
Thank you,
Carol


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98487/new/

https://reviews.llvm.org/D98487



More information about the cfe-commits mailing list