[PATCH] D93164: [AST] Add generator for source location introspection

Sun Mar 14 08:47:34 PDT 2021

steveire added a comment.

In D93164#2624760 <https://reviews.llvm.org/D93164#2624760>, @dmgreen wrote:

> Hello. Does this work when the default target triple isn't native? This seems to be trying to compile clang sources with the just built clang - something that I don't think is always possible. I'm seeing errors like `fatal error: 'cstddef' file not found`, and failing to link the new IntrospectionTests, with undefined references to NodeIntrospection::GetLocations, as a full toolchain is not setup. I don't believe the buildbots are working right now, so it's difficult to see if any other systems have similar problems.

Can you report if running `cmake . -DCLANG_TOOLING_BUILD_AST_INTROSPECTION=OFF` allows you to complete the build?

Is there some way I can check that the default target triple isn't native in the cmake code? Then I can set that option automatically.

> Also some of the files here have been added with a University of Illinois Open Source License. They should presumably be using the newer Apache license now.

Fixed, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93164/new/

https://reviews.llvm.org/D93164