[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Mar 14 08:13:24 PDT 2021
hubert.reinterpretcast added inline comments.
================
Comment at: clang/bindings/python/clang/cindex.py:2061-2062
TypeKind.FLOAT128 = TypeKind(30)
TypeKind.HALF = TypeKind(31)
+TypeKind.IBM128 = TypeKind(32)
TypeKind.COMPLEX = TypeKind(100)
----------------
This looks suspiciously like the result of this file having not been maintained for the additions of:
```
CXType_Float16 = 32,
CXType_ShortAccum = 33,
CXType_Accum = 34,
CXType_LongAccum = 35,
CXType_UShortAccum = 36,
CXType_UAccum = 37,
CXType_ULongAccum = 38,
CXType_BFloat16 = 39,
```
What test coverage fails if the addition of `TypeKind.IBM128` is omitted from this patch?
================
Comment at: clang/include/clang-c/Index.h:3283
CXType_FirstBuiltin = CXType_Void,
CXType_LastBuiltin = CXType_BFloat16,
----------------
Looks like `CXType_Ibm128` is the "last" built-in type now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93377/new/
https://reviews.llvm.org/D93377
More information about the cfe-commits
mailing list