[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

Matheus Izvekov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 13 17:25:23 PST 2021


mizvekov updated this revision to Diff 330484.
mizvekov added a comment.

- Uses yet another simpler approach: Since dependence should not matter (we were using the type of the expression after template instantiation anyway), we don't even need to build a `decltype` type here, and just get the canonical type from the `(expr)` instead. Kudos to rsmith for this suggestion in private.
- Adds some more tests, testing more kinds of values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98160/new/

https://reviews.llvm.org/D98160

Files:
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Sema/Sema.h
  clang/lib/Sema/SemaConcept.cpp
  clang/lib/Sema/SemaExprCXX.cpp
  clang/lib/Sema/SemaType.cpp
  clang/test/CXX/expr/expr.prim/expr.prim.req/compound-requirement.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98160.330484.patch
Type: text/x-patch
Size: 8938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210314/48e22c84/attachment-0001.bin>


More information about the cfe-commits mailing list