[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

[Xiangling Liao via Phabricator via cfe-commits]

Xiangling_L marked 2 inline comments as done.
Xiangling_L added inline comments.


================
Comment at: clang/include/clang/Basic/LLVM.h:25
 #include "llvm/ADT/None.h"
+// Add this header as a workaround to unblock the XL build compiler issue.
+#include "llvm/ADT/SmallVector.h"
----------------
RKSimon wrote:
> Is there a better comment? "unblock the XL build compiler issue" isn't going to mean much to someone in the future....
How about "Add this header as a workaround to prevent "too few template arguments for class template 'SmallVector' ""? Or do you have any suggestion?


================
Comment at: clang/include/clang/Basic/LLVM.h:38
   template<typename T, unsigned N> class SmallVector;
   template<typename T> class SmallVectorImpl;
   template<typename T> class Optional;
----------------
RKSimon wrote:
> Should these 2 forward declarations be removed?
Thanks. will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98552/new/

https://reviews.llvm.org/D98552