[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 12 13:44:58 PST 2021


RKSimon added inline comments.


================
Comment at: clang/include/clang/Basic/LLVM.h:25
 #include "llvm/ADT/None.h"
+// Add this header as a workaround to unblock the XL build compiler issue.
+#include "llvm/ADT/SmallVector.h"
----------------
Is there a better comment? "unblock the XL build compiler issue" isn't going to mean much to someone in the future....


================
Comment at: clang/include/clang/Basic/LLVM.h:38
   template<typename T, unsigned N> class SmallVector;
   template<typename T> class SmallVectorImpl;
   template<typename T> class Optional;
----------------
Should these 2 forward declarations be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98552/new/

https://reviews.llvm.org/D98552



More information about the cfe-commits mailing list